LGTM + nits
http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JSRunner.cpp File plugins/xpcom/JSRunner.cpp (right): http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JSRunner.cpp#newcode121 plugins/xpcom/JSRunner.cpp:121: Debug::log(Debug::Error) << "Get JSPrincial at JSRunner::eval: " << object indentation is off here http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JSRunner.cpp#newcode127 plugins/xpcom/JSRunner.cpp:127: std::string script2("alert(window.__static)"); looks like you meant to delete this block before review? http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JavaObject.cpp File plugins/xpcom/JavaObject.cpp (right): http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JavaObject.cpp#newcode108 plugins/xpcom/JavaObject.cpp:108: #if GECKO_VERSION >= 13000 the preprocessor statements should not have indentation http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JavaObject.h File plugins/xpcom/JavaObject.h (right): http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JavaObject.h#newcode38 plugins/xpcom/JavaObject.h:38: #if GECKO_VERSION >= 13000 unnecessary http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/Makefile File plugins/xpcom/Makefile (right): http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/Makefile#newcode167 plugins/xpcom/Makefile:167: CFLAGS += -DGECKO_VERSION=13000 this is really starting to be a really messy chain of if statements. consider cleaning this up. http://gwt-code-reviews.appspot.com/1738803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
