http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JSRunner.cpp File plugins/xpcom/JSRunner.cpp (right):
http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JSRunner.cpp#newcode121 plugins/xpcom/JSRunner.cpp:121: Debug::log(Debug::Error) << "Get JSPrincial at JSRunner::eval: " << object On 2012/06/11 17:30:31, conroy wrote:
indentation is off here
Deleted. http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JSRunner.cpp#newcode127 plugins/xpcom/JSRunner.cpp:127: std::string script2("alert(window.__static)"); On 2012/06/11 17:30:31, conroy wrote:
looks like you meant to delete this block before review?
Yes. Oops. http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JavaObject.cpp File plugins/xpcom/JavaObject.cpp (right): http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JavaObject.cpp#newcode108 plugins/xpcom/JavaObject.cpp:108: #if GECKO_VERSION >= 13000 On 2012/06/11 17:30:31, conroy wrote:
the preprocessor statements should not have indentation
Done. http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JavaObject.h File plugins/xpcom/JavaObject.h (right): http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JavaObject.h#newcode38 plugins/xpcom/JavaObject.h:38: #if GECKO_VERSION >= 13000 On 2012/06/11 17:30:31, conroy wrote:
unnecessary
Done. http://gwt-code-reviews.appspot.com/1738803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
