http://gwt-code-reviews.appspot.com/1727807/diff/8001/user/src/com/google/gwt/editor/client/impl/DelegateMap.java File user/src/com/google/gwt/editor/client/impl/DelegateMap.java (right):
http://gwt-code-reviews.appspot.com/1727807/diff/8001/user/src/com/google/gwt/editor/client/impl/DelegateMap.java#newcode132 user/src/com/google/gwt/editor/client/impl/DelegateMap.java:132: nit: blank lines http://gwt-code-reviews.appspot.com/1727807/diff/8001/user/src/com/google/gwt/editor/client/impl/DelegateMap.java#newcode136 user/src/com/google/gwt/editor/client/impl/DelegateMap.java:136: * Locates the closest valid parents to the absolute path. Returns the path fragment the was the was -> that was http://gwt-code-reviews.appspot.com/1727807/diff/8001/user/src/com/google/gwt/editor/client/impl/DelegateMap.java#newcode140 user/src/com/google/gwt/editor/client/impl/DelegateMap.java:140: public String getClosestValidParentsByPath( The API of this method is rather hard to follow with "out" parameters in order to work around Java's lack of multiple return values. Maybe we can avoid the whole issue by moving most of the code in the for loop in SimpleViolation to this class? /** * Sends an error to the closest matching editor. */ public void reportError(SimpleViolation violation) { } It's enough code that I'd imagine you'd want to extract helper methods for readability, but at least they can be private. http://gwt-code-reviews.appspot.com/1727807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
