LGTM. I commented on some issues to fix in later patches.



http://gwt-code-reviews.appspot.com/1727808/diff/16001/distro-source/build.xml
File distro-source/build.xml (right):

http://gwt-code-reviews.appspot.com/1727808/diff/16001/distro-source/build.xml#newcode39
distro-source/build.xml:39: <zipfileset
file="${gwt.build.lib}/gwt-elemental.jar" prefix="${project.distname}"
/>
I wonder if this target should just die in that case? (I'm assuming most
developers don't build the distribution, but if you do, it should
include elemental.)

http://gwt-code-reviews.appspot.com/1727808/diff/16001/elemental/build.xml
File elemental/build.xml (right):

http://gwt-code-reviews.appspot.com/1727808/diff/16001/elemental/build.xml#newcode60
elemental/build.xml:60: <delete dir="idl/generated" />
This is good for now, but we probably want to change the python scripts
to take an output directory and put the files under "build". (We had to
work around the same issue in the google build.)

http://gwt-code-reviews.appspot.com/1727808/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to