http://gwt-code-reviews.appspot.com/1727808/diff/8001/build.xml File build.xml (right):
http://gwt-code-reviews.appspot.com/1727808/diff/8001/build.xml#newcode41 build.xml:41: <call-subproject subproject="elemental" subtarget="build" /> On 2012/06/15 00:34:59, skybrian wrote:
I asked Ray about this. Elemental is experimental and its build
process is
rather interesting (and probably not very portable), so maybe we
shouldn't build
it by default?
Done.
We should still include the jar in a binary distribution, though.
What's the
best way to handle that in ant?
I've kept the <zipfileset> in distro-source/build.xml and it seems to pass even if the JAR isn't there. It means that to release the GWT SDK (and then deploy the artifacts to Maven), you'll have to run "ant clean elemental dist" instead of just "ant clean dist". I've added a warning in case you try to build a SDK without Elemental, unfortunately it's burried into the Ant output, so you'd better use "ant -q clean dist" to see it. To that effect, I suppressed a bunch of warnings elsewhere in the build. I also changed the maven deploy script to silently ignore gwt-elemental.jar if it's not there. http://gwt-code-reviews.appspot.com/1727808/diff/8001/build.xml#newcode131 build.xml:131: <call-subproject subproject="elemental" subtarget="checkstyle" /> On 2012/06/15 00:34:59, skybrian wrote:
I think this is okay so long as we only check style on the
manually-written
code. We can do that without running the generator.
Actually, the default checkstyle target (inherited from common.ant.xml) is a no-op, so I removed that line and we'll add it back when we fully integrate Elemental to the build. http://gwt-code-reviews.appspot.com/1727808/diff/8001/build.xml#newcode144 build.xml:144: <call-subproject subproject="elemental" subtarget="test" /> On 2012/06/15 00:34:59, skybrian wrote:
Let's defer this until after we've moved the tests to open source.
Done. http://gwt-code-reviews.appspot.com/1727808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
