On Thursday, July 12, 2012 2:56:06 AM UTC+2, Eric Friesen wrote: > > This occurs in the ValueProxyCategory: > > > http://code.google.com/searchframe#T04cSGC7sWI/trunk/user/src/com/google/web/bindery/requestfactory/shared/impl/ValueProxyCategory.java&q=ValueProxyCategory%20package:google-web-toolkit%5C.googlecode%5C.com&l=42 > > It's causing our project to not be able to compare our AutoBean objects > returned to us from RequestFactory requests. Would a change to check > whether the AutoBeans have stable ids in the first place before trying to > compare their proxy classes be acceptable? Or am I missing something in the > big picture here and it's a bad idea. As far as I can tell it's an > optimization to fail early without having to do a deep equals and this > change would be alright. If this sounds reasonable I'll put in a fix for > review. >
The thing is: stableId shouldn't ever be 'null', that'd be a bug. Maybe you create a ValueProxy AutoBean without using RequestContext#create(); that's not supported, that'd be a bug in your code. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
