http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/HTTP.gwt.xml
File user/src/com/google/gwt/http/HTTP.gwt.xml (right):

http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/HTTP.gwt.xml#newcode31
user/src/com/google/gwt/http/HTTP.gwt.xml:31: <when-property-is
Why is this wrapped?  It looks like each when-property-is element should
fit on a single line.

http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/client/RequestImplIE69.java
File user/src/com/google/gwt/http/client/RequestImplIE69.java (right):

http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/client/RequestImplIE69.java#newcode28
user/src/com/google/gwt/http/client/RequestImplIE69.java:28: final
Response original = super.createResponse(xmlHttpRequest);
This requires two objects to be created instead of one.  Could you
instead change the anonymous Response classes into actual response
classes so that RequestImplIE69's Response implementation can extend and
override RequestImpl's Response implementation?  Then
RequestImplIE69.createResponse() should only need to create one object
and not need so many boiler plate forwarding methods.

http://gwt-code-reviews.appspot.com/1875803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to