Thanks for the feedback.

http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/HTTP.gwt.xml
File user/src/com/google/gwt/http/HTTP.gwt.xml (right):

http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/HTTP.gwt.xml#newcode31
user/src/com/google/gwt/http/HTTP.gwt.xml:31: <when-property-is
This is a style I got used too. I'll fix that.

http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/client/RequestImpl.java
File user/src/com/google/gwt/http/client/RequestImpl.java (right):

http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/client/RequestImpl.java#newcode22
user/src/com/google/gwt/http/client/RequestImpl.java:22: public class
RequestImpl {
I'll do the 'impl' package-way because it is done this ways in many
places.

http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/client/RequestImpl.java#newcode75
user/src/com/google/gwt/http/client/RequestImpl.java:75: Header[]
getHeaders(XMLHttpRequest xmlHttp) {
I thought it's a good style to move out all the special implementation
logic which is not bound to a Response instance.

http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/client/RequestImplIE69.java
File user/src/com/google/gwt/http/client/RequestImplIE69.java (right):

http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/client/RequestImplIE69.java#newcode24
user/src/com/google/gwt/http/client/RequestImplIE69.java:24: public
class RequestImplIE69 extends RequestImpl {
Yes, the issue is fixed in IE10
(http://blogs.msdn.com/b/ieinternals/archive/2012/03/01/ie10-beta-consumer-preview-minor-changes-changelist.aspx)

I'll rename the class.

http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/client/RequestImplIE69.java#newcode28
user/src/com/google/gwt/http/client/RequestImplIE69.java:28: final
Response original = super.createResponse(xmlHttpRequest);
Good idea. I'll do that.

http://gwt-code-reviews.appspot.com/1875803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to