Brian Slesinsky has posted comments on this change.
Change subject: Changes StackTraceDeobfuscator to abstract and provide
various factory methods.
......................................................................
Patch Set 2:
(3 comments)
....................................................
File user/src/com/google/gwt/core/server/impl/StackTraceDeobfuscator.java
Line 65: throw new MissingResourceException("Missing resource: "
+ filePath, null, filePath);
Should be FileNotFoundException, to agree with the javadoc.
Line 86: public static StackTraceDeobfuscator fromURL(final URL urlPath) {
Google style would be "fromUrl" instead of "fromURL". In GWT it seems to be
inconsistent - there is UrlBuilder and UrlUtils but there is also
GWT.getModuleBaseURL.
Line 89: return new URL(urlPath, fileName).openStream();
I don't know if this will throw FileNotFoundException if there is a 404 (or
equivalent for other protocols).
--
To view, visit https://gwt-review.googlesource.com/2270
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I562e052caef8da7f3434319cf11b8984bc347fe5
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
