Brian Slesinsky has posted comments on this change.
Change subject: Changes StackTraceDeobfuscator to abstract and provide
various factory methods.
......................................................................
Patch Set 2:
(2 comments)
....................................................
File user/src/com/google/gwt/core/server/impl/StackTraceDeobfuscator.java
Line 89: return new URL(urlPath, fileName).openStream();
MissingResourceException is a RuntimeException, not an IOException. It
shouldn't be used in openInputStream because it won't be caught at line 378
like the others.
But I think you're right, it seems too difficult to consistently throw
FileNotFoundException. Maybe we should just wrap the call to
openInputStream (by itself) and catch IOException.
Line 338: * @param fileName name of the symbol or source map file (not
including a slash)
I meant that the filename doesn't include any directories (not a path).
--
To view, visit https://gwt-review.googlesource.com/2270
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I562e052caef8da7f3434319cf11b8984bc347fe5
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
