Thomas Broyer has posted comments on this change.
Change subject: Widget Iterator now throws NoSuchElementExceptions
correctly.
......................................................................
Patch Set 2:
(1 comment)
I can't tell whether it's _supposed_ to happen (probably not), but I can
confirm that it *does* happen.
One issue is that line lengths in comments changed from 80 to 100 but files
haven't been reformatted as a whole. There were some commits that consisted
only of reformatting in prevision of big changes in the code. For small
changes, I think the general rule is to simply avoid making any
reformatting.
It's relatively easy to reformat all files, so maybe we should do it once
and for all.
The other issue is sometimes changes in javadoc comments for "empty lines":
adding/removing a space after the asterisk.
....................................................
File user/src/com/google/gwt/user/client/ui/WidgetCollection.java
Line 45: if (index + 1 >= size) {
This actually needs to be +1, because of the
array[++index]
Er. isn't "index + 1 >= size" equivalent to "index > size" ?
--
To view, visit https://gwt-review.googlesource.com/2440
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07fd1507226a185b94ae1e85b6eb0235ec370a9f
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
