Goktug Gokdogan has posted comments on this change.
Change subject: Widget Iterator now throws NoSuchElementExceptions
correctly.
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
....................................................
File user/test/com/google/gwt/user/client/ui/WidgetCollectionTest.java
Line 173: }
Test cases look pretty good.
Usually it is best to have separate tests for different cases so that you
have better reporting from test failures. Also Google practice is using
testMethod_testScenario as the test name (e.g. testIterator_doubleRemove)
but I'm not sure if GWT uses the same convention.
--
To view, visit https://gwt-review.googlesource.com/2440
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07fd1507226a185b94ae1e85b6eb0235ec370a9f
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
