Matthew Dempsky has posted comments on this change.

Change subject: Remove dependency from GWT-JUnit on deRPC
......................................................................


Patch Set 2:

It is definitely the deRPC tests at the bottom of RPCSuite. Commenting them out fixes the test failure. I'm trying to determine now which tests specifically are at fault, or whether it's all of them.

Maybe we can just move the deRPC tests into a separate test suite?

I'm curious if this is going to be a backwards compatibility issue for users at all. I notice one internal Google user each for RpcServlet and HybridServiceServlet. I'll have to check if there test cases are affected by this change at all. :/

--
To view, visit https://gwt-review.googlesource.com/1290
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74c9d2e339187c2a47ccea4b0082c3a59ffe5ae4
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: James Nelson <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to