James Nelson has posted comments on this change.
Change subject: Remove dependency from GWT-JUnit on deRPC
......................................................................
Patch Set 2:
The tests that were commented out simply extend the other tests that run
through a normal RemoteServiceServlet. The only difference is they use a
different .gwt.xml module that loads up extensions of HybridServiceServlet
which extends deRPCs RpcServlet.
If legacy support is needed, than a JUnitHostDeRPCImpl that still extends
HybridServiceServlet should be used instead. Given that it's deprecated
and being phased out though, this change should likely be made only in the
projects that require it.
Additionally, it might save users trouble debugging if the StringIndexOOB
is caught, and wrapped in a message that says "You are using the deprecated
deRPC RpcServlet instead of the preferred RemoteServiceServlet.".
The StringIndexOOB is reliably thrown when using a RemoteService interface
on a deRPC servlet (unless the payload contains '~'); deRPC scans for a
separator char of ~, which is not a special char in standard rpc.
It's actually rather confusing, since both servlets call an
RPC.decodeRequest() command, but from two different RPC classes.
c.g.g.rpc.server.SimplePayloadDecoder is where the OOB happens, and is
where the message to switch from RpcServlet to RemoteServiceServlet should
likely be placed.
--
To view, visit https://gwt-review.googlesource.com/1290
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74c9d2e339187c2a47ccea4b0082c3a59ffe5ae4
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: James Nelson <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
