Matthew Dempsky has posted comments on this change.
Change subject: Make sub/superclass queries in JTypeOracle more efficient.
......................................................................
Patch Set 2:
(2 comments)
Seems okay, but I'll defer to you compiler guys. :)
....................................................
File dev/core/src/com/google/gwt/dev/jjs/ast/JClassType.java
Line 95: return classId;
Perhaps add an
assert classId != -1;
here?
Line 103: this.classId = classId;
And an
assert this.classId == -1;
here?
--
To view, visit https://gwt-review.googlesource.com/2701
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe256bc07834b1518a9e90872fdd655e3e242790
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
