John Stalcup has posted comments on this change.
Change subject: Make sub/superclass queries in JTypeOracle more efficient.
......................................................................
Patch Set 4: Code-Review+1
(8 comments)
seems like it would be nice to have a test to show that deserialized type
oracles do recalculate these class hierarchy ids
....................................................
File dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java
Line 307: private int declaredTypesSize;
declaredTypesCount
Line 706:
superflous multiple blank lines
Line 1042:
superflous blank line
Line 1045: * Compute class ids for efficient lookups.
"for efficient subtype checking"
Line 1058: private transient int lastClassId = -1;
we already have seedIds, queryIds, and now classIds in the compiler.
the comments you have here are good but maybe we could make the classId
name more specific as well to reduce ambiguity
Line 1061: boolean isSubtype(JClassType sub, JClassType sup) {
can this be private?
Line 1072: maxDescendants = new int[declaredTypesSize];
both the words "descendants" and "subclasses" are being used in this
change. maybe only one or the other should be used
Line 1077: private void computeIdTraversal(JClassType type) {
s/computeIdTraversal/computeIdForClass
--
To view, visit https://gwt-review.googlesource.com/2701
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe256bc07834b1518a9e90872fdd655e3e242790
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: John Stalcup <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
