Matthew Dempsky has posted comments on this change.

Change subject: Workaround JSONTest failure in Firefox 17
......................................................................


Patch Set 1:

This is an ugly hack, but it'll finally allow us to switch our internal testing from Firefox 3.6 to Firefox 17 (ESR).

I don't know why calling .isNull() on a JSONObject instance could return a non-null value, but only on FF17. I'm wondering if there could be a compiler optimization bug at play? Or maybe there's a FF17 VM bug that we need to workaround? (Hopefully not...)

Either way, unless anyone can see a downside to this patch, I'd like to submit it so we can finally drop Firefox 3.6 internally.

--
To view, visit https://gwt-review.googlesource.com/2734
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c79c5279a122748047b23d068e2eed4ad9fb22f
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: John Stalcup <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to