Thomas Broyer has posted comments on this change.
Change subject: Workaround JSONTest failure in Firefox 17
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Did you have any chance of looking at the -draft JS to try to understand
what's happening there? I'd blame Firefox's JS engine here but maybe it has
roots in how we generate the JS.
....................................................
File user/src/com/google/gwt/json/client/JSONNull.java
Line 53: if (this != instance) {
Wow this is getting really strange: you're saying that isNull on JSONObject
et al. returns a non-null value and you're modifying isNull of JSONNull to
workaround it?!
--
To view, visit https://gwt-review.googlesource.com/2734
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c79c5279a122748047b23d068e2eed4ad9fb22f
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: John Stalcup <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
