Thomas Broyer has posted comments on this change.
Change subject: Add SafeUri overloads for setting properties used for
navigation
......................................................................
Patch Set 4:
I just looked at what we did back when we added SafeUri: we added overloads.
Thinking more about it, I also honestly don't think clearing an Anchor,
FormPanel or Frame's URL is a valid use-case: those things *need* a URL and
are useless without one. Using Anchors without a URL is an anti-pattern:
use a Button instead (or a Label/InlineLabel with the appropriate ARIA
attributes). For frames, I think you can just set about:blank if you really
need/want to clear it.
In brief: yes it's a (slightly) breaking change, but we didn't bother with
backwards compat in earlier similar changes, and those are edge-cases or
anti-patterns; so let's just keep the overloads.
--
To view, visit https://gwt-review.googlesource.com/2663
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ab7a472b0c0c4470f00f7178de216f7c7e4e415
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Guillaume Ryder <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Patrick Tucker <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
