Matthew Dempsky has posted comments on this change.
Change subject: Add SafeUri overloads for setting properties used for
navigation
......................................................................
Patch Set 4:
Yeah, renaming setInnerSafeHtml(SafeHtml) to just setInnerHTML(SafeHtml)
would make things more consistent.
Checking internally, I only see two calls to "setInnerHTML(null)", and one
of them is in the open source Wave code. ;) So even less risk of breaking
existing users there I think.
I see a *lot* of calls to setInnerSafeHtml() though, so we'd probably need
to keep the current method as a @Deprecated forwarding method for a few
releases.
--
To view, visit https://gwt-review.googlesource.com/2663
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ab7a472b0c0c4470f00f7178de216f7c7e4e415
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Guillaume Ryder <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Patrick Tucker <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
