Jens Nehlmeier has posted comments on this change.
Change subject: Fix ValuePicker.setValue(T) to no longer fire events.
......................................................................
Patch Set 2: Code-Review+1
Looks good.
The only minor nip-pick would be that calling setValue() with "true" inside
the SingleSelectionModel handler probably doesn't do anything as it seems
like that the SingleSelectionModel selection and the ValuePicker's value
are always in sync => setValue() would always return early.
But technically, calling setValue() with true from the the
SingleSelectionModel handler isn't wrong.
--
To view, visit https://gwt-review.googlesource.com/2980
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
