Thomas Broyer has submitted this change and it was merged.
Change subject: Fix ValuePicker.setValue(T) to no longer fire events.
......................................................................
Fix ValuePicker.setValue(T) to no longer fire events.
Bug: issue 7330
Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a
---
M user/src/com/google/gwt/user/client/ui/ValuePicker.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Jens Nehlmeier: Looks good to me, but someone else must approve
Goktug Gokdogan: Looks good to me, approved
diff --git a/user/src/com/google/gwt/user/client/ui/ValuePicker.java
b/user/src/com/google/gwt/user/client/ui/ValuePicker.java
index 45ced21..5914791 100644
--- a/user/src/com/google/gwt/user/client/ui/ValuePicker.java
+++ b/user/src/com/google/gwt/user/client/ui/ValuePicker.java
@@ -64,7 +64,7 @@
cellList.setSelectionModel(smodel);
smodel.addSelectionChangeHandler(new SelectionChangeEvent.Handler() {
public void onSelectionChange(SelectionChangeEvent event) {
- setValue(smodel.getSelectedObject());
+ setValue(smodel.getSelectedObject(), true);
}
});
}
@@ -112,7 +112,7 @@
}
public void setValue(T value) {
- setValue(value, true);
+ setValue(value, false);
}
public void setValue(T value, boolean fireEvents) {
--
To view, visit https://gwt-review.googlesource.com/2980
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
