Thomas Broyer has posted comments on this change.
Change subject: Adds support for lower case encoding names to String
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Only nits within tests; the fix is otherwise OK.
....................................................
File user/test/com/google/gwt/emultest/java/lang/StringTest.java
Line 612:
nit: remove whitespace
Line 613: private void testConstructorLatin1(String encoding) throws
UnsupportedEncodingException {
nit: can you move those private methods right below the test methods that
call them?
--
To view, visit https://gwt-review.googlesource.com/3000
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9532ba1e7e6e863093727e354f7f3174229c2ab
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Honza Rameš <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
