John A. Tamplin has posted comments on this change.
Change subject: Adds support for lower case encoding names to String
......................................................................
Patch Set 2:
If you are going for the regex, you probably want to create the pattern
once and reuse it rather than creating a new pattern every time. Also,
doesn't the pattern need to be anchored?
I don't care much either way -- I can't imagine that looking up a character
set is going to be very common.
--
To view, visit https://gwt-review.googlesource.com/3000
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9532ba1e7e6e863093727e354f7f3174229c2ab
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Honza Rameš <[email protected]>
Gerrit-Reviewer: Honza Rameš <[email protected]>
Gerrit-Reviewer: James Nelson <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
