Thomas Broyer has posted comments on this change.
Change subject: Add static is(...) to complement as as(...).
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Could you add a test (not for all elements) in ElementTest#testIsOrAs ?
....................................................
File user/src/com/google/gwt/dom/client/AnchorElement.java
Line 38:
nit: whitespace
Line 41: * A <code>null</code> node will cause this method to return
This is not what's implemented: null will cause an exception.
Line 45: return elem.getTagName().equalsIgnoreCase(TAG);
Couldn't this use hasTagName(TAG) ?
--
To view, visit https://gwt-review.googlesource.com/2976
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14aa6163e52adb2f71cd1ca3557ff3514571a6a2
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roy Paterson <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
