Thomas Broyer has posted comments on this change.
Change subject: Add static is(...) to complement as as(...).
......................................................................
Patch Set 1:
(1 comment)
....................................................
File user/src/com/google/gwt/dom/client/AnchorElement.java
Line 41: * A <code>null</code> node will cause this method to return
Given that the various existing as() and is() methods all accept null, I'd
rather accept it and do as the javadoc says (i.e. fix the code rather than
the doc).
I also wonder if we should add a is(Node) and is(JavaScriptObject) like in
Element (Element redefines a is(JavaScriptObject) and adds a is(Element);
we could redefine both those methods and add the is(Element)):
public static boolean is(JavaScriptObject o) {
if (Element.is(o)) {
return is((Element) o);
}
return false;
}
public static boolean is(Node node) {
if (Element.is(node)) {
return is((Element) node);
}
return false;
}
Maybe we could do that in a later patch if you don't feel like adding them
now, let's see what others think.
--
To view, visit https://gwt-review.googlesource.com/2976
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14aa6163e52adb2f71cd1ca3557ff3514571a6a2
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roy Paterson <[email protected]>
Gerrit-Reviewer: Roy Paterson <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
