Goktug Gokdogan has posted comments on this change.
Change subject: ActivityManager fails to clear Eventbus
......................................................................
Patch Set 1: Code-Review-2
This doesn't look safe.
The API permits setDisplay to be called any time and any number of times
and unfortunately semantics are unfortunately not very clear for different
scenarios. Currently, calling setDisplay with 'null' doesn't cause stop
behavior on activities which means, they are still active in active state.
If you call remove handlers, it will break the active Activity. Safe thing
to do is to actually, stop the active Activity and let it remove the
handlers and the next time setDisplay is called with a new display
reactivate the activity with the correct display. I can imagine even that
behavior will potentially break some projects.
--
To view, visit https://gwt-review.googlesource.com/2974
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ffb6911b0723969001bd43c73059b4dfad104cf
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
