Jens Nehlmeier has posted comments on this change.
Change subject: ActivityManager fails to clear Eventbus
......................................................................
Patch Set 1:
Maybe adding an explicit dispose() method would be suitable. Calling
dispose() will set the display to null and tear down any active activity.
With such a dispose() method we could even disallow calling setDisplay()
with null. That would mean you could only swap displays which would trigger
an activity restart as Goktug described it. This would tighten up the API a
bit but I can only hardly see a use case where you want to call
setDisplay() with null other than for cleanup.
--
To view, visit https://gwt-review.googlesource.com/2974
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ffb6911b0723969001bd43c73059b4dfad104cf
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
