Jens Nehlmeier has posted comments on this change.
Change subject: Update how columns are hidden in CellTable.
......................................................................
Patch Set 2:
(1 comment)
....................................................
File user/src/com/google/gwt/user/cellview/client/CellTable.java
Line 830: boolean isColumnVisible = !"0".equals(width)
&& !"0px".equals(width);
columnElement.getStyle().setProperty("width",....) does not care about the
unit used to define the width.
Maybe we should add checks for remaining units as well. At least 0% could
be common to use in public AbstractCellTable.setColumnWidth(col, width).
The public API does not restrict to pixels only.
--
To view, visit https://gwt-review.googlesource.com/3130
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49fd531a02ca0a1a55eabba5548670ad86273a43
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
