Brian Slesinsky has posted comments on this change.
Change subject: Update how columns are hidden in CellTable.
......................................................................
Patch Set 3:
(1 comment)
....................................................
File user/src/com/google/gwt/user/cellview/client/CellTable.java
Line 827: TableColElement columnElement =
ensureTableColElement(column);
Looks like we have to roll this back. Here's an internal comment:
Hi,
It appears that this change has broken our build, as well as the behavior
of cell tables in general.
When you set column to "0", it doesn't really hide the column.
The problem is described below.
According to the CSS specificaton [1]
"table-column (In HTML: COL)
Specifies that an element describes a column of cells.
...
The default style sheet for HTML4 in the appendix illustrates the use of
these values for HTML4:
....
col { display: table-column }"
So here, when we call setVisible(columnElement, isColumnVisible) with
isColumnVisible = false, it makes changes CSS attribute "display"
to "none", and the column element loses its "table-column" properties, and
its "width" attributes do not propagate to the <th> and <td> elements
(because this element is not a table-column and does not describe a column
of cells).
[1] http://www.w3.org/TR/CSS21/tables.html#table-display
--
To view, visit https://gwt-review.googlesource.com/3130
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49fd531a02ca0a1a55eabba5548670ad86273a43
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
