Stephen Haberman has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
......................................................................
Patch Set 1:
(2 comments)
....................................................
File user/src/com/google/gwt/dom/client/DOMImpl.java
Line 196: return (int) getSubpixelAbsoluteLeft(elem) | 0;
Out of curiosity, this bug asserts that "| 0" was sometimes flaky in
Mozilla and that something like Math.ceil (or round?) would be better:
https://code.google.com/p/google-web-toolkit/issues/detail?id=6991
Do you have any thoughts on that?
....................................................
File user/src/com/google/gwt/dom/client/DOMImplMozilla.java
Line 133: elem);
getAbsoluteLeftImpl returns an int and has a "| 0" that, per the comment,
is related to coercion to an int--should that be changed to return a double?
--
To view, visit https://gwt-review.googlesource.com/3090
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27e98f0ad3c1c236b2d85d24f197719fa4cd352a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos <[email protected]>
Gerrit-Reviewer: Artur Signell <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
