John Ahlroos has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
......................................................................
Patch Set 2:
Subpixel values was first introduced by IE10 I believe, so it is a rather
new thing and I think not many have used them before.
The sub-pixel values comes handy when you need to do pixel perfect
layouting which needs to work on different zoom levels as well. Widgets
like tables and panels which need to measure the widgets and position them
tightly beside each other really benefits from using the exact values
rather than the rounded ones. We have a lot of those widgets in Vaadin. A
common defect we usually see when not using sub pixel values is that on
IE10 when user zooms in our widgets does not scale correctly and 1px gaps
appear or then widgets start to wrap. It is in these cases subpixel would
be preferred.
Basically it would be preferable for anyone to use the subpixel variants
always when either measuring elements or doing pixel perfect positioning.
Since we cannot change the current return values of the DOM methods we need
a equally convenient way of using the subpixel values so people will prefer
using them instead. If we hide them behind a cast people will still
continue to use the round values and hit problems which we are seeing today.
--
To view, visit https://gwt-review.googlesource.com/3090
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27e98f0ad3c1c236b2d85d24f197719fa4cd352a
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos <[email protected]>
Gerrit-Reviewer: Artur Signell <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: John Ahlroos <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
