Brian Slesinsky has posted comments on this change.
Change subject: The job of defineSeed is to mark the existence of a class
and associate its castMap with the class's various constructors.
......................................................................
Patch Set 2:
(1 comment)
This is too deep for me to review so I'll leave it to Ray and Roberto. A
surface comment:
....................................................
Commit Message
Line 7: The job of defineSeed is to mark the existence of a class and
associate its castMap with the class's various constructors.
The first line of a commit should be a short summary line that makes sense
to people not familiar with GWT internals ("Fix a bug in the codesplitter")
Then say when the bug could happen ("The bug occurs when a class has
multiple constructors...") and link to the issue.
Then go into the detailed explanation of how you fixed it.
--
To view, visit https://gwt-review.googlesource.com/3300
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Stalcup <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: John Stalcup <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
