Roberto Lublinerman has posted comments on this change.
Change subject: The job of defineSeed is to mark the existence of a class
and associate its castMap with the class's various constructors.
......................................................................
Patch Set 2:
(2 comments)
I had too comments here that where not published.
....................................................
File dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java
Line 246
Is this no longer valid or was just removed because we normally run the
compiler with assertions disabled? Assertions are enabled when running
tests so if it still valid that extractStatements is only called once then
we should leave the assertion.
Line 191: * been made live by the current fragment. It also counts the
constructors the references that
Remove "the" between constructor references?
--
To view, visit https://gwt-review.googlesource.com/3300
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Stalcup <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: John Stalcup <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
