Thomas Broyer has posted comments on this change.
Change subject: Fix for 8188
(http://code.google.com/p/google-web-toolkit/issues/detail?id=8188)
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
....................................................
Commit Message
Line 7: Fix for 8188
Please describe what the change is about. E.g.
Log excluded resources in DirectoryClassPathEntry the same way as
ZipFileClassPathEntry
(we should add something to the makinggwtbetter page)
Line 8: (http://code.google.com/p/google-web-toolkit/issues/detail?id=8188)
If you use "issue 8188", Gerrit will "linkify" it. Even better, if you use:
Bug: issue 8188
as a footer line (next to Change-Id, no blank line between them, but blank
line before the footer) the review will be searchable with "tr:8188" in
Gerrit.
....................................................
File
dev/core/src/com/google/gwt/dev/resource/impl/DirectoryClassPathEntry.java
Line 39:
Trailing space; strange that it passed checkstyle…
--
To view, visit https://gwt-review.googlesource.com/3380
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c25c0e486e02a3b5ed1a8804d5276cebc0877c6
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Denis Anisimov <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
