Thomas Broyer has posted comments on this change.
Change subject: Add interfaces for widgets.
......................................................................
Patch Set 6:
(4 comments)
I've only looked at a few files.
....................................................
File user/src/com/google/gwt/user/client/ui/IndexedPanel.java
Line 34: * Extends this interface with convenience methods to handle
{@link IsWidget}.
IsWidget2 ?
....................................................
File user/src/com/google/gwt/user/client/ui/IsImage.java
Line 34: void setUrl(String url);
Do we really want to expose those unsafe methods? Shouldn't we try to make
people use SafeUri instead?
....................................................
File user/src/com/google/gwt/user/client/ui/IsUIObject.java
Line 27: IsElement getIsElement();
Given that Element implements IsElement, and we already have getElement(),
couldn't we just declare
IsElement getElement();
here and take advantage of covariant return types in UIObject?
....................................................
File user/src/com/google/gwt/user/client/ui/Panel.java
Line 118: return new IsWidgetIteratorAdaptor(iterator());
Given that Widget implements IsWidget2 could we just take advantage of type
erasure and do an unchecked cast?
return (Iterator<IsWidget2>) ((Iterator) iterator());
--
To view, visit https://gwt-review.googlesource.com/3231
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd17162d37e367720829bcdaf9a350e446c833b9
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <stephen.haber...@gmail.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
