Goktug Gokdogan has posted comments on this change.

Change subject: Add interfaces for widgets.
......................................................................


Patch Set 8:

I thought "IsXXX" just meant "we really wanted to name this interface just 'XXX', but that name was already taken by the concrete class

That doesn't fit into current IsXXX because if it was you wouldn't need IsWidget2 :)
I'm not good at coming up with great names but perhaps IXXX would be better.

Well, I read the github page for gwt-mockito, and I believe we have different opinions on what constitutes a "mess" :-).

With rejecting that, you basically rejecting mocking libs which is very common practice for testing in java :)

As a distilled/simplified example, what I do is, roughly:

You cannot do what you exactly want to do with in any widget library in Java (AWT, SWT, Swing, Android) out of the box. So what you are proposing is actually a uncommon request :)

Also I think, we can still do do something similar by mocking options.

For example, instead of generating new StubElement() you can generate StubFactory.createElement(). createElement will return Mockito.when(any(), <answer>). "Answer" can be implemented by just using naming conventions (i.e. store x on setX and return it on getX) or it can forward calls to your handwritten StubElement - which doesn't need to extend the StubElement.

You can even do this without gwt-mockito.

Anyway, what I mean is, I think you can still achieve exactly what you want and have the same development experience without the extra interfaces.

--
To view, visit https://gwt-review.googlesource.com/3231
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd17162d37e367720829bcdaf9a350e446c833b9
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Colin Alworth <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to