Goktug Gokdogan has posted comments on this change.
Change subject: Set display to none for table columns that should not be
visible.
......................................................................
Patch Set 1:
(3 comments)
....................................................
File user/src/com/google/gwt/user/cellview/client/CellTable.java
Line 905:
ensureTableColElement(i).getStyle().setDisplay(Display.NONE);
I think this has the same issue as before isn't it?
If I correctly understood the previous issue, if the column display is set
to none, the width was not propagating.
That will still be true for columns that was not visible before (hence
display is set to none) and become just visible. Their width will be set in
super.refreshColumnWidth when the display is still 'none'.
Line 909: }
Let's do 2 loops and avoid the unnecessary if checks:
for (int i = 0; i < lastColumn; i++) {
ensureTableColElement(i).getStyle().clearDisplay();
}
for (int i = lastColumn; i < colCount; i++) {
doSetColumnWidth(i, "0px");
ensureTableColElement(i).getStyle().setDisplay(Display.NONE);
}
....................................................
File user/test/com/google/gwt/user/cellview/client/CellTableTest.java
Line 301: assertEquals(Display.NONE.toString().toLowerCase(),
you can just change this to "none" if you like.
--
To view, visit https://gwt-review.googlesource.com/3390
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5eabeda8a3ef2f7b851d540c3776026984654c3
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Aliseya Wright <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
