Goktug Gokdogan has posted comments on this change.
Change subject: Set display to none for table columns that should not be
visible.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File user/src/com/google/gwt/user/cellview/client/CellTable.java
Line 905:
ensureTableColElement(i).getStyle().setDisplay(Display.NONE);
Actually I'm referring to what he originally said but I'm talking about
some other potential problems.
In the original email (you might have not seen it) Alan said,
"...it makes changes CSS attribute "display" to "none", and the column
element loses its "table-column" properties, and its "width" attributes do
not propagate to the <th> and <td> elements (because this element is not a
table-column and does not describe a column of cells)..."
so I thought that with your change we will have a problem with columns
transitioning from hidden to visible. If the column was hidden and made
just visible again the "setWidth" calls from super.refreshColumnWidths()
will not be propagated to the cells because "display" property is not
a "table-column".
--
To view, visit https://gwt-review.googlesource.com/3390
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5eabeda8a3ef2f7b851d540c3776026984654c3
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Aliseya Wright <[email protected]>
Gerrit-Reviewer: Aliseya Wright <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
