Manuel Carrasco Moñino has posted comments on this change.
Change subject: making RootPanel.clear(true) respects GWT loader iframei
......................................................................
Patch Set 1:
(2 comments)
....................................................
File user/src/com/google/gwt/user/client/ui/RootPanel.java
Line 329: if (!shouldNodeBeRemoved(child)) {
Why are you maintaining a list with this nodes?, I think you just skip them
instead of detaching reataching
if (shouldNodeBeRemoved()) {
containerElement.removeChild()
}
Line 346: && GWT.getModuleName().equals(childElement.getId())) {
What about the __gwtHistoryFrame, it is still being used in IE6 History. I
think if we remove it we will break History in this permutation.
I know we are getting rid of IE6 in future releases though.
--
To view, visit https://gwt-review.googlesource.com/3430
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Manuel Carrasco Moñino <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
