Manuel Carrasco Moñino has posted comments on this change.
Change subject: making RootPanel.clear(true) respects GWT loader iframe
......................................................................
Patch Set 5:
(1 comment)
....................................................
File user/src/com/google/gwt/user/client/ui/RootPanel.java
Line 340: && GWT.getModuleName().equals(childElement.getId())) {
- This code does not work with real browsers unless you change it to the
code below, Because Element.hasTagName() is case-sensitive and compares the
argument against getTagName() which always returns UPPERCASE (see:
http://www.w3schools.com/jsref/prop_element_tagname.asp).
childElement.hasTagName(IFrameElement.TAG.toUpperCase())
A simpler solution could be to get the iframe before the loop and compare it
moduleIframe = DOM.getElementById(GWT.getModuleName()) ;
if (!childElement.equals(moduleIframe)) {} ...
- NOTICE: I think we must preserve the '<script>' with
the 'moduleName.nocache.js' as well. Some times the user adds it to the
body instead of to the head. I think that if we remove it, XS linker would
not load next fragments.
Out of subject: In these cases I miss css selectors in gwt, something like:
nodesToRemove = DOM.querySelectorAll("body > :not(#moduleName)");
--
To view, visit https://gwt-review.googlesource.com/3430
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Manuel Carrasco Moñino <manuel.carrasc...@gmail.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
