Colin Alworth has posted comments on this change.
Change subject: Ensure clinits get called for JSO instance methods.
......................................................................
Patch Set 2:
(2 comments)
....................................................
File user/test/com/google/gwt/dev/jjs/test/JsoTest.java
Line 49: static final class ClinitStaticFieldFirst extends
JavaScriptObject {
Correct - the commit message documents this, but I'll stick a comment too.
Line 54: if (FIELD == null) {
Again, commit message touched on it. The bug only manifests in compiled
code, and the compiler will inline this if it is too simple. I was going
for the simplest code I could write that would not be optimized out (at
least in draft mode) without using JSNI. Not that there is an issue with
JSNI here, just that I wanted to keep the issue on track for following Java
semantics. Once the method gets inlined, the bug goes away, since the
outside code is accessing the field, and any static field access requires a
clinit (which the compiler doesn't forget before this patch).
--
To view, visit https://gwt-review.googlesource.com/3361
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If09885382bcf2d6c149cd8e48bfdd3ae527d67cb
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Colin Alworth <[email protected]>
Gerrit-Reviewer: Colin Alworth <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
