Colin Alworth has posted comments on this change.
Change subject: Ensure clinits get called for JSO instance methods.
......................................................................
Patch Set 2:
(1 comment)
....................................................
File dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java
Line 172: if (program.isStaticImpl(x.getTarget())
&& !program.isJavaScriptObject(x.getTarget().getEnclosingType())) {
The extra condition (both here and in GenerateJavaScriptAST) deals with the
fact that MakeCallsStatic registers instance methods as static with
JProgram, while JsoDevirtualizer does not. This seems reasonable at first,
though since JSOs are *always* made static, there might be other
implications. I suggested this in my first comment in this change request,
but John seemed to think that this approach made more sense. That said, I
haven't actually tried making that change, and seeing what else is affected
(i.e. all other callsites of JProgram.isStaticImpl or .getStaticImpl).
--
To view, visit https://gwt-review.googlesource.com/3361
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If09885382bcf2d6c149cd8e48bfdd3ae527d67cb
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Colin Alworth <[email protected]>
Gerrit-Reviewer: Colin Alworth <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
