Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
......................................................................
Patch Set 8:
Hi Colin, the only approach in selecting classes is that these are what I'd
used so far, plus a few others.
For the remaining 10%-ish, I could add the low-hanging fruit in this CL,
but I could also see adding them lazily/in a future patch. Either way I
would anticipate having them eventually.
Good catch on IsNumberLabel not extending IsValueLabel; fixed (but not
uploaded yet).
Adding documentation/guidelines is a good idea; assuming/after this gets
+2'd (but before a release), I'll add something to the gwt site.
--
To view, visit https://gwt-review.googlesource.com/3231
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd17162d37e367720829bcdaf9a350e446c833b9
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Colin Alworth <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
