Goktug Gokdogan has posted comments on this change.
Change subject: adds regression testing against future changes that might
accidentally push all fragment code into the leftover fragment
......................................................................
Patch Set 4:
(4 comments)
Thanks for separating the test. It looks pretty good.
....................................................
File user/src/com/google/gwt/core/client/impl/XhrLoadingStrategy.java
Line 32: protected class XhrDownloadStrategy implements DownloadStrategy {
I think alternatively we can avoid changing any production code via
creating our own loading strategy subclassing of XhrDownloadStrategy and
RequestData.
Something like:
public class LoggingXhrLoadingStrategy extends LoadingStrategyBase {
public static Map<Integer, String> sourceByFragmentIndex = new
HashMap<Integer, String>();
public XhrLoadingStrategy() {
super(new XhrDownloadStrategy() {
@Override
public void tryDownload(final RequestData request) {
super.tryDownload(new RequestData(){
public void tryInstall(String code) {
super.tryInstall(code);
sourceByFragmentIndex.put(request.getFragment(), code);
}
});
}
});
}
....................................................
File user/test/com/google/gwt/dev/jjs/test/RunAsyncContentTest.java
Line 44: public void onFailure(Throwable caught) {}
We can report the exception for failing faster:
reportUncaughtException(caught);
Line 55: public void testUniqueContentRegular() {
(nit) you may consider naming methods like following:
testUniqueContent
testUniqueContentWithClassListeral
....................................................
File user/test/com/google/gwt/dev/jjs/test/RunAsyncFailureTest.java
Line 250: }
I guess this wasn't intentional?
--
To view, visit https://gwt-review.googlesource.com/3590
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Stalcup <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: John Stalcup <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
