John Stalcup has posted comments on this change.
Change subject: Adds a regression test for fragment splitting
......................................................................
Patch Set 5:
(5 comments)
....................................................
Commit Message
Line 7: adds regression testing against future changes that might
accidentally push all fragment code into the leftover fragment
Done
Line 7: adds regression testing against future changes that might
accidentally push all fragment code into the leftover fragment
Done
....................................................
File user/src/com/google/gwt/core/client/impl/LoadingStrategyBase.java
Line 114:
i'm being consistent with the file.
do you want me to:
1. reformat the whole file,
2. be different from the rest of the file, or
3. be consistent with the file?
....................................................
File user/test/com/google/gwt/dev/jjs/test/LoggingXhrLoadingStrategy.java
Line 49: super.tryDownload(new
com.google.gwt.core.client.impl.LoadingStrategyBase.RequestData(
it was conflicting with
com.google.web.bindery.requestfactory.shared.impl.RequestData and something
to do with the class hierarchy (before the most recent change you
requested) was making the wrong one resolve first and organize import fail
repeatedly
seems to be working correctly now. i've removed the FQN
....................................................
File user/test/com/google/gwt/dev/jjs/test/RunAsyncContentTest.java
Line 66: String sharedContent = "Same String in multiple
fragments.";
it can't be that, because then it ends up in the initial fragment (i tried
it that way first). also i can't check for the existence of a class or
field because the names are obfuscated randomly. i think we're kind of
stuck with this shared interned String
--
To view, visit https://gwt-review.googlesource.com/3590
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Stalcup <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: John Stalcup <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
