Stephen Haberman has posted comments on this change.
Change subject: Optimize initializing fields at the top scope.
......................................................................
Patch Set 3:
(1 comment)
....................................................
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
Line 2342: canObserveSubclassFields.add(currentClass);
Roberto: Ignoring calls to cstrs of this/super makes sense--they will get
their own endVisit checks. $init I will look in to. Ignoring 0-arg static
calls makes sense too.
Brian: I believe what Roberto is saying is that the other cstr calls will
have their contents checked by their own
visit(JConstructor)/endVisit(JMethodCall)s, so if we see a method call from
1 cstr to another cstr in the same class, we can assume it will get checked
later, and the cstr->cstr call itself doesn't mean we have to mark the
currentClass as observing subclass fields.
--
To view, visit https://gwt-review.googlesource.com/3440
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97a06eb36396a8b8659ce9a025b21a9cf93d0500
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
