Matthew Dempsky has posted comments on this change.
Change subject: Optimize initializing fields at the top scope.
......................................................................
Patch Set 5:
(2 comments)
....................................................
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
Line 2216: * Technically, to match JVM semantics, we should only do
this for final or static fields. For
Sounds like something we could add a test for?
Line 2225: if (x.getLiteralInitializer() != null) {
Just as an aside, Go programming has made me accustomed to trying to
restructure conditionals to minimize block nesting. E.g.,
if (x.getLiteralInitializer() == null) {
return false;
}
if (x.isFinal() || x.isStatic()) {
return true;
}
JDeclaredType current = ...;
...
But I'll leave it up to you/Roberto to decide whether that actually makes
the code more readable or not.
--
To view, visit https://gwt-review.googlesource.com/3440
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97a06eb36396a8b8659ce9a025b21a9cf93d0500
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
