Thomas Broyer has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
......................................................................
Patch Set 1:
(3 comments)
Maybe ResettableEventBus should be retrofitted to use this class.
....................................................
File
user/src/com/google/web/bindery/event/shared/HandlerRegistrationCollection.java
Line 37: * {@link HandlerRegistration}s
I think it should be written {@link HandlerRegistration
HandlerRegistrations}
(same in the javadoc for the class)
Line 41: public static HandlerRegistrationCollection
create(HandlerRegistration... handlers) {
Not sure this helper factory method is a good addition to the API.
Line 49: private LinkedList<HandlerRegistration> handlers = new
LinkedList<HandlerRegistration>();
AFAICT LinkedList is almost always a bad choice (JVM, Android, GWT).
FWIW, ResettableEventBus uses a HashSet.
--
To view, visit https://gwt-review.googlesource.com/3661
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75ccd120b78e1be47fa6a1e4f20c607c68203c31
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
