Thomas Broyer has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Nits only. I think I like that approach better than the previous one (while
not ruling it out as a future addition)
....................................................
File user/src/com/google/web/bindery/event/shared/HandlerRegistrations.java
Line 17: * A utility class to help deal with {@link HandlerRegistration
HandlerRegistrations}.
Given the class is now called HandlerRegistrations, I think we should use
{@link HandlerRegistration handler registrations} instead (here and below)
Line 52: * return HandlerRegistrationCollection.compose(hr1, hr2);
s/HandlerRegistrationCollection/HandlerRegistrations/
--
To view, visit https://gwt-review.googlesource.com/3661
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75ccd120b78e1be47fa6a1e4f20c607c68203c31
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
